-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 0.8.0 checklist #58
Comments
Not too bad of a delay I guess, and the things it adds seem worth it.
I'd personally vote for having a minimum viable release first (eg, without filtering/
I don't feel like this is worth blocking 0.8.0 on; it's not like adding it will be a huge breaking change. |
I think that works; I think (but I'm not 100% sure) that
Agreed -- I'm quite sure that it is a purely additive change; |
Since 1.27 only stabilises the |
Not sure; it should still be possible to implement My primary motivation for 1.27 is There are some (Probably won't have time to finish (Haven't had time to work enough on Showable and Shrinkable Closures -- so it should for sure not block 0.8) |
Possible, yes, but the types aren't well-defined enough for a one-size-fits-all solution.
Addressed those and all others that looked immediately fixable. Let me know if I missed something; if not, I'll get 0.8.0 published fairly soon. |
Alright; Given that we bumped to 1.27, it can be easily added without breakage if we find a good way in the future and someone needs implementations of those :)
Nice work! ❤️ I have one concern re. the movement towards
https://blog.rust-lang.org/2018/06/21/Rust-1.27.html In Rust 1.27 you can use There's also #[must_use = "iterator adaptors are lazy and do nothing unless consumed"] |
Right, I had intended on moving to that. Thanks for pointing it out.
Good suggestion, I'll see where that applies. |
Yep, which is why I did it across the board now rather than planning on adopting it opportunistically. IMHO the way it simplifies function signatures in the docs is worth the small risk that it breaks someone's code, especially since we have a whole slew of minor breaking changes in this version anyway. |
0.8.0 is released |
Hurray! 🦀 |
Some proposed TODOs for version 0.8.0:
Benefits:
Iterator::try_fold
RangeInclusive::{start, end}
become available.SIMD stuff...Strategy for RangeInclusive<T>
whereT
is a float (which requires.start()
and.end()
).#[cfg(MIN_1_127)]
logic if we want to make v0.8.0 available for 1.26.0.Arbitrary
for SIMD stuff;#[cfg(MIN_1_127)]
logic if we want to make v0.8.0 available for 1.26.0.Landproptest_derive
quote
,proc-macro2
,syn
crates.prob
attribute on enum variantsLand some form of "showable & shrinkable closures" a la [Test.QuickCheck.Function](https://hackage.haskell.org/package/QuickCheck-2.11.3/docs/Test-QuickCheck-Function.html)The text was updated successfully, but these errors were encountered: