Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using null instead of empty strings #36

Open
konklone opened this issue Jul 16, 2017 · 9 comments
Open

Using null instead of empty strings #36

konklone opened this issue Jul 16, 2017 · 9 comments
Assignees

Comments

@konklone
Copy link
Contributor

In general, using null instead of "" will be semantically more clear in communicating when there is no value for a field, versus when the value for a field is an empty string.

For example, if a legislator has no YouTube account, the value should ideally be null instead of "".

@dwillis
Copy link
Collaborator

dwillis commented Jul 16, 2017

Working on this.

@dwillis dwillis self-assigned this Jul 16, 2017
@dwillis
Copy link
Collaborator

dwillis commented Jul 19, 2017

This is mostly done and in the API now. Will review the remaining responses and update as needed.

@konklone
Copy link
Contributor Author

Flagging: the meeting_type and url fields on the hearings endpoint use empty strings instead of nulls.

@konklone
Copy link
Contributor Author

Flagging: the action_id field on (Senate) floor updates uses empty strings instead of nulls.

@konklone
Copy link
Contributor Author

konklone commented Aug 5, 2017

Flagging: the tie_breaker and tie_breaker_vote fields on Senate votes are empty strings instead of nulls when no tie breaking vote took place.

@konklone
Copy link
Contributor Author

Flagging: committee memberships have a couple of empty string fields:

                 "note": "",
                 "begin_date":""

@konklone
Copy link
Contributor Author

konklone commented Sep 3, 2017

Flagging: times_topics_url fields on legislators have empty strings.

@konklone
Copy link
Contributor Author

konklone commented Sep 3, 2017

Flagging: I've found an empty string used for middle_name on legislators (see Edward Royce for an example).

@dwillis
Copy link
Collaborator

dwillis commented Sep 3, 2017

Will fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants