Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Npm run test command not working as expected #925

Closed
dereklieu opened this issue Feb 1, 2016 · 2 comments
Closed

Npm run test command not working as expected #925

dereklieu opened this issue Feb 1, 2016 · 2 comments

Comments

@dereklieu
Copy link
Member

In node 4.0, running npm test is no longer printing test results to console. Seems to just hang there.

Probably related to mocha-phantom moving core to a different module after 4.0.

This would be a good reason to upgrade the node version we're pegging this to.

@jmatsushita
Copy link

Hi there @dereklieu

I was looking at how things are with regards to testing in Prose given that you mentioned needing more tests to do regression testing on some cool PRs (like the ProseMirror integration #935 )

I came by this issue and couldn't reproduce it locally switching with nvm to node 4.0, 4.1 or 4.2. I thought I'd give a shot at building a fork with travis across all known node_js version to see if it caught something but it seems sane and passes and displays test results to the console except on 0.6 and 0.8.

Cheers,

Jun

@dereklieu
Copy link
Member Author

@jmatsushita you're right, I just did a fresh npm install on 4.2.4 and it worked fine. Closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants