Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update configurations to latest pyproject.toml #68

Closed
baggiponte opened this issue Jan 9, 2024 · 4 comments
Closed

Update configurations to latest pyproject.toml #68

baggiponte opened this issue Jan 9, 2024 · 4 comments

Comments

@baggiponte
Copy link

baggiponte commented Jan 9, 2024

Hey there. I opened a similar issue before Christmas on NVIDIA's NeMoGuardrail project. The latest Python standards recommend to configure the project with pyproject.toml over setup.py for several reasons - including, for example, the possibility to list build-time dependencies.

The so-called build backends (specified in PEPs 517 518) can read from pyproject.toml stuff such as the README, the dependencies and the version dynamically, so you won't have to maintain those.

Plus, I had a question: is there a reason for you to pin the dependencies with == constraints? are there any know incompatibilities with all these libraries? Generally Python libraries are not meant to be distributed with == in other cases but with >= to ensure compatibility. With == constraints, llm-guard installation might fail when attempting to install in an environment with conflicting deps.

I could implement a similar thing as I did here.

@asofter
Copy link
Collaborator

asofter commented Jan 11, 2024

Hey @baggiponte , thanks for the suggestions. I am kicking off preparation for the next release, and this is first on my list.

@asofter
Copy link
Collaborator

asofter commented Jan 11, 2024

On the library version constraints, there are a few dependencies where it makes difference like torch but mostly it doesn't, so I made a change for that as well.

@asofter
Copy link
Collaborator

asofter commented Jan 11, 2024

Updated, thank you for the suggestion: https://github.com/laiyer-ai/llm-guard/blob/main/pyproject.toml

@baggiponte
Copy link
Author

Thanks! Closing the issue :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants