Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge troika-3d-text package into troika-3d #121

Open
lojjic opened this issue Apr 29, 2021 · 0 comments
Open

Merge troika-3d-text package into troika-3d #121

lojjic opened this issue Apr 29, 2021 · 0 comments

Comments

@lojjic
Copy link
Collaborator

lojjic commented Apr 29, 2021

The troika-3d-text package has had an interesting evolution.

  • It originally contained everything related to text rendering, coupled tightly with the troika-3d framework package.
  • When it became obvious it was useful/needed in the larger Three.js community, it was given a custom standalone build file that decoupled the Three.js code from the troika-3d framework code.
  • Then for better ergonomics all the standalone code was extracted to the new generic troika-three-text package.
  • That left just Text3DFacade and the partially-completed helpers for text selection.
  • Now work is underway to move the text selection logic into troika-three-text too, so it will be just the Text3DFacade remaining.

It doesn't really make sense to have a separate package for just that. So I'd like to move Text3DFacade into troika-3d and retire the troika-3d-text package. Bloating the troika-3d package size isn't an issue I don't think, and it should be treeshakeable if unused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant