Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

asJson is converting long values with 0 to undefined #616

Closed
robin-anil opened this issue Jan 4, 2017 · 1 comment
Closed

asJson is converting long values with 0 to undefined #616

robin-anil opened this issue Jan 4, 2017 · 1 comment

Comments

@robin-anil
Copy link
Contributor

smells like a javascript falsy bug

screen shot 2017-01-03 at 7 17 18 pm
@dcodeIO dcodeIO closed this as completed in 9035d48 Jan 4, 2017
@robin-anil
Copy link
Contributor Author

robin-anil commented Jan 4, 2017 •
edited

@dcodeIO I don't think the fix you made is entirely correct. Server has set the value 0 and is sending it. The client should be converting the since field to 0 and should not be removing it.

..thoughts?

@robin-anil robin-anil mentioned this issue Jan 4, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@robin-anil