Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Top level enums #7

Closed
baliw opened this issue Mar 21, 2013 · 2 comments
Closed

Top level enums #7

baliw opened this issue Mar 21, 2013 · 2 comments
Assignees
@dcodeIO
Labels
bug resolved

Comments

@baliw
Copy link

baliw commented Mar 21, 2013

First of all, great library! It's great to see a 100% js alternative to the protobuf-for-node library.

I'm working with a .proto file that has top level enum definitions that are shared among two different messages. ProtoBuf.js claims "Illegal top level declaration", but Google's protoc compiles it just fine. I'm somewhat new to protobufs, but I would think if Google's protoc was ok with it, then it would be a good idea to follow suit.
@ghost ghost assigned dcodeIO Mar 21, 2013
@dcodeIO
Copy link
Member

dcodeIO commented Mar 21, 2013

Thank you for reporting this! I was not sure if top-level enums are supported in protoc, so I might have skipped that. I will look into this and let you know.

@dcodeIO
Copy link
Member

dcodeIO commented Mar 23, 2013

I've also updated the npm package, missed that before.

@dcodeIO dcodeIO mentioned this issue Jul 1, 2013
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dcodeIO dcodeIO

Labels
bug resolved
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@baliw @dcodeIO