Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace all goog.asserts calls with new custom asserting functions #136

Closed
lukesandberg opened this issue Sep 28, 2022 · 0 comments · Fixed by #137
Closed

Replace all goog.asserts calls with new custom asserting functions #136

lukesandberg opened this issue Sep 28, 2022 · 0 comments · Fixed by #137
Assignees
@dibenede
Labels
cleanup triaged Issue has been triaged

Comments

@lukesandberg
Copy link
Contributor

as part of #128 we are inadvertently disabling all goog.asserts calls (this is an intended side effect of ADVANCED_COMPILATION)

we should instead migrate to our own asserting functions that will survive compilation. This will also further progress on #135
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dibenede dibenede

Labels
cleanup triaged Issue has been triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace goog.asserts and goog.testing.asserts dibenede/protobuf-javascript
2 participants
@lukesandberg @dibenede