Reduce the required alignment of ArenaString from 8 to 4 #10298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangskz
approved these changes
Jul 22, 2022
zhangskz
requested changes
Jul 22, 2022
There was a problem hiding this comment.
Unapproving for now, though this looks good.
We may opt to instead sync this to github + cp to release branch from the internal change to avoid future sync conflict. However, the conflict isn't too bad anyways so I think this will depend on if we need to sync other changes for the next patch release anyways.
zhangskz
approved these changes
Jul 25, 2022
|
Re-approving to get this into 21.x for 21.4 release. |
klzgrad
added a commit
to klzgrad/naiveproxy
that referenced
this pull request
Sep 1, 2022
klzgrad
added a commit
to klzgrad/naiveproxy
that referenced
this pull request
Oct 1, 2022
klzgrad
added a commit
to klzgrad/naiveproxy
that referenced
this pull request
Oct 1, 2022
klzgrad
added a commit
to klzgrad/naiveproxy
that referenced
this pull request
Oct 1, 2022
klzgrad
added a commit
to klzgrad/naiveproxy
that referenced
this pull request
Nov 2, 2022
klzgrad
added a commit
to klzgrad/naiveproxy
that referenced
this pull request
Nov 2, 2022
klzgrad
added a commit
to klzgrad/naiveproxy
that referenced
this pull request
Nov 3, 2022
klzgrad
added a commit
to klzgrad/naiveproxy
that referenced
this pull request
Dec 3, 2022
klzgrad
added a commit
to klzgrad/naiveproxy
that referenced
this pull request
Jan 11, 2023
klzgrad
added a commit
to klzgrad/naiveproxy
that referenced
this pull request
Jan 11, 2023
klzgrad
added a commit
to klzgrad/naiveproxy
that referenced
this pull request
Jan 14, 2023
klzgrad
added a commit
to klzgrad/naiveproxy
that referenced
this pull request
Feb 19, 2023
klzgrad
added a commit
to klzgrad/naiveproxy
that referenced
this pull request
Feb 19, 2023
klzgrad
added a commit
to klzgrad/naiveproxy
that referenced
this pull request
Feb 19, 2023
klzgrad
added a commit
to klzgrad/naiveproxy
that referenced
this pull request
Feb 19, 2023
klzgrad
added a commit
to klzgrad/naiveproxy
that referenced
this pull request
Mar 13, 2023
ahn254
pushed a commit
to ahn254/chromium
that referenced
this pull request
Aug 22, 2023
ahn254
pushed a commit
to ahn254/chromium
that referenced
this pull request
Aug 22, 2023
ahn254
pushed a commit
to ahn254/chromium
that referenced
this pull request
Aug 25, 2023
ahn254
pushed a commit
to ahn254/chromium
that referenced
this pull request
Aug 27, 2023
ahn254
pushed a commit
to ahn254/chromium
that referenced
this pull request
Sep 2, 2023
klzgrad
added a commit
to klzgrad/naiveproxy
that referenced
this pull request
Sep 11, 2023
klzgrad
added a commit
to klzgrad/naiveproxy
that referenced
this pull request
Sep 12, 2023
ahn254
pushed a commit
to ahn254/chromium
that referenced
this pull request
Sep 27, 2023
ahn254
pushed a commit
to ahn254/chromium
that referenced
this pull request
Sep 27, 2023
ahn254
pushed a commit
to ahn254/chromium
that referenced
this pull request
Sep 27, 2023
ahn254
pushed a commit
to ahn254/chromium
that referenced
this pull request
Sep 29, 2023
ahn254
pushed a commit
to ahn254/chromium
that referenced
this pull request
Oct 7, 2023
klzgrad
added a commit
to klzgrad/naiveproxy
that referenced
this pull request
Oct 13, 2023
klzgrad
added a commit
to klzgrad/naiveproxy
that referenced
this pull request
Oct 13, 2023
klzgrad
added a commit
to klzgrad/naiveproxy
that referenced
this pull request
Oct 13, 2023
ahn254
pushed a commit
to ahn254/chromium
that referenced
this pull request
Oct 16, 2023
ahn254
pushed a commit
to ahn254/chromium
that referenced
this pull request
Oct 16, 2023
ahn254
pushed a commit
to ahn254/chromium
that referenced
this pull request
Oct 16, 2023
ahn254
pushed a commit
to ahn254/chromium
that referenced
this pull request
Oct 16, 2023
ahn254
pushed a commit
to ahn254/chromium
that referenced
this pull request
Oct 16, 2023
ahn254
pushed a commit
to ahn254/chromium
that referenced
this pull request
Oct 16, 2023
klzgrad
added a commit
to klzgrad/naiveproxy
that referenced
this pull request
Nov 5, 2023
klzgrad
added a commit
to klzgrad/naiveproxy
that referenced
this pull request
Nov 5, 2023
klzgrad
added a commit
to klzgrad/naiveproxy
that referenced
this pull request
Nov 5, 2023
sleeyax
pushed a commit
to sleeyax/cronet-binaries
that referenced
this pull request
Nov 24, 2023
klzgrad
added a commit
to klzgrad/naiveproxy
that referenced
this pull request
Dec 10, 2023
klzgrad
added a commit
to klzgrad/naiveproxy
that referenced
this pull request
Dec 10, 2023
klzgrad
added a commit
to klzgrad/naiveproxy
that referenced
this pull request
Dec 10, 2023
klzgrad
added a commit
to klzgrad/naiveproxy
that referenced
this pull request
Jan 19, 2024
klzgrad
added a commit
to klzgrad/naiveproxy
that referenced
this pull request
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current 21.3 release breaks gRPC android due to this alignment requirement. Verified that reducing it to 4, makes it work again.