Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Struct-like type that supports integers #13094

Closed
erinboyle opened this issue Jun 17, 2023 · 3 comments
Closed

Add new Struct-like type that supports integers #13094

erinboyle opened this issue Jun 17, 2023 · 3 comments
Assignees
Labels
enhancement inactive Denotes the issue/PR has not seen activity in the last 90 days.

Comments

@erinboyle
Copy link

We're using protobuf 2 to pass messages python <-> scala. I need to pass flexible nested dictionaries from python and their integer values need to stay integers, so struct won't work.

I see you have good reasons you can't add int to Struct Values. But what if you added a new type instead? (Porting my comment over.) E.g. StructWithInt, which would prioritize supporting int to the exclusion of whichever other constraints are in the way.

Thanks for considering. Would be excited to migrate away from passing my proto message as the string, json.dumps(dict).

@erinboyle erinboyle added the untriaged auto added to all issues by default when created. label Jun 17, 2023
@mkruskal-google mkruskal-google added enhancement and removed untriaged auto added to all issues by default when created. labels Jun 21, 2023
@fowles
Copy link
Member

fowles commented Jun 22, 2023

generally speaking, we avoiding adding new "well known types" they tend to have a fairly high long term maintenance cost for us. I recommend creating the type you need local toyour particular project.

Copy link

github-actions bot commented Nov 9, 2023

We triage inactive PRs and issues in order to make it easier to find active work. If this issue should remain active or becomes active again, please add a comment.

This issue is labeled inactive because the last activity was over 90 days ago.

@github-actions github-actions bot added the inactive Denotes the issue/PR has not seen activity in the last 90 days. label Nov 9, 2023
Copy link

We triage inactive PRs and issues in order to make it easier to find active work. If this issue should remain active or becomes active again, please reopen it.

This issue was closed and archived because there has been no new activity in the 14 days since the inactive label was added.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement inactive Denotes the issue/PR has not seen activity in the last 90 days.
Projects
None yet
Development

No branches or pull requests

3 participants