Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zlib(BUILD.bazel): Maybe it would be better to use @platforms instead of @bazel_tools? #13250

Closed
4kangjc opened this issue Jul 9, 2023 · 2 comments

Comments

@4kangjc
Copy link
Contributor

4kangjc commented Jul 9, 2023

Hi! Maybe it would be better to use @platforms instead of @bazel_tools?

copts = select({
"@bazel_tools//src/conditions:windows": [],
"//conditions:default": [
"-Wno-deprecated-non-prototype",
"-Wno-unused-variable",
"-Wno-implicit-function-declaration",
],
}),

 copts = select({ 
     "@platforms//os:windows": [], 
     "//conditions:default": [ 
         "-Wno-deprecated-non-prototype", 
         "-Wno-unused-variable", 
         "-Wno-implicit-function-declaration", 
     ], 
 }), 
@4kangjc 4kangjc added the untriaged auto added to all issues by default when created. label Jul 9, 2023
@acozzette
Copy link
Member

That sounds like a good idea. If you would like to send a PR with this change then I would be happy to review it.

@acozzette acozzette added help wanted and removed untriaged auto added to all issues by default when created. labels Jul 14, 2023
@4kangjc
Copy link
Contributor Author

4kangjc commented Jul 14, 2023

That sounds like a good idea. If you would like to send a PR with this change then I would be happy to review it.

OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants