Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a module-info.java #16133

Open
sgammon opened this issue Mar 13, 2024 · 4 comments · May be fixed by #16502
Open

Add a module-info.java #16133

sgammon opened this issue Mar 13, 2024 · 4 comments · May be fixed by #16502

Comments

@sgammon
Copy link
Contributor

sgammon commented Mar 13, 2024

What language does this apply to?
If it's a proto syntax change, is it for proto2 or proto3? N/A
If it's about generated code change, what programming language? Java

Describe the problem you are trying to solve.
I want to use Protobuf Java with jlink. Unfortunately, jlink rejects JARs with an Automatic-Module-Name set; it is required to define a module-info.java.

Describe the solution you'd like
I would like Protobuf Java to ship a module-info.java, in an MRJAR, to preserve existing JDK support. I am not proposing a change to the JVM bytecode minimum support level.

Describe alternatives you've considered
I have considered solutions like Moditect, but they complicate my build greatly because dependencies must be transformed before being consumed by the Java Compiler.

Additional context
Guava is considering a PR for this. Recently, Error Prone and other core libs have released new versions with a module-info.java definition. Thus, Protobuf's transitive dependencies may be ready for a fully modular Java build.

@sgammon sgammon added the untriaged auto added to all issues by default when created. label Mar 13, 2024
This was referenced Mar 14, 2024
@sgammon sgammon linked a pull request Apr 15, 2024 that will close this issue
Copy link

We triage inactive PRs and issues in order to make it easier to find active work. If this issue should remain active or becomes active again, please add a comment.

This issue is labeled inactive because the last activity was over 90 days ago.

@github-actions github-actions bot added the inactive Denotes the issue/PR has not seen activity in the last 90 days. label Jun 11, 2024
@sgammon
Copy link
Contributor Author

sgammon commented Jun 11, 2024

Bump!

@github-actions github-actions bot removed the inactive Denotes the issue/PR has not seen activity in the last 90 days. label Jun 12, 2024
@shaod2 shaod2 removed the untriaged auto added to all issues by default when created. label Jul 9, 2024
@odinsbane
Copy link

I don't understand why this can't be done. It seems like jlink is a great way to create a stand alone app, but we cannot use protobuf with it.

@vietj
Copy link

vietj commented Jul 15, 2024

We are willing to help on this effort, we would like very much to have JPMS support for Google Protobuf library

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants