Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ruby] ffi-compiler 1.3.1 breaks google-protobuf installation on JRuby #16150

Closed
ntkme opened this issue Mar 13, 2024 · 2 comments
Closed

[Ruby] ffi-compiler 1.3.1 breaks google-protobuf installation on JRuby #16150

ntkme opened this issue Mar 13, 2024 · 2 comments
Labels
untriaged auto added to all issues by default when created.

Comments

@ntkme
Copy link
Contributor

ntkme commented Mar 13, 2024

What version of protobuf and what language are you using?
Version: 4.26.0/3.25.3
Language: Ruby

What operating system (Linux, Windows, ...) and version?

This issue is OS independent that it happens on all OS.

What runtime / compiler are you using (e.g., python version or gcc version)

JRuby 9.4.6.0

What did you do?

gem install google-protobuf

What did you expect to see

Gem successfully installed.

What did you see instead?

ERROR: Failed to build gem native extension.

This appears to be a regression from ffi-compiler 1.3.1 which is released today, however the details of this regression is unknown:
ffi/ffi-compiler#26

Anything else we should know about your project / environment
https://github.com/sass-contrib/sass-embedded-host-ruby/actions/runs/8271884102/job/22632613467

@ntkme ntkme added the untriaged auto added to all issues by default when created. label Mar 13, 2024
@ntkme
Copy link
Contributor Author

ntkme commented Mar 13, 2024

ffi-compiler gem is completely untested according to its maintainer's comment here, so it's not surprising at all that a new release breaks protobuf installation.

@acozzette I think this is probably a good reason to prioritize #15555 to remove ffi-compiler and rake dependency.

@ntkme ntkme changed the title ffi-compiler 1.3.1 breaks google-protobuf installation on JRuby [Ruby] ffi-compiler 1.3.1 breaks google-protobuf installation on JRuby Mar 13, 2024
@ntkme
Copy link
Contributor Author

ntkme commented Mar 14, 2024

ffi-compiler 1.3.2 fixed the issue.

@ntkme ntkme closed this as completed Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
untriaged auto added to all issues by default when created.
Projects
None yet
Development

No branches or pull requests

1 participant