Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file_mask.proto is missing a go_package #2057

Closed
tswast opened this issue Sep 2, 2016 · 2 comments
Closed

file_mask.proto is missing a go_package #2057

tswast opened this issue Sep 2, 2016 · 2 comments
Labels

Comments

@tswast
Copy link
Contributor

tswast commented Sep 2, 2016

https://github.com/google/protobuf/blob/master/src/google/protobuf/field_mask.proto

This file probably needs

option go_package = "github.com/golang/protobuf/ptypes/fieldmask";

I have filed golang/protobuf#226 to track including it in the Go protobuf package.

@tswast
Copy link
Contributor Author

tswast commented Sep 2, 2016

I am working on writing conformance tests for Go and this is needed (mostly because Go doesn't do really relative imports and the Go protobuf compiler doesn't support compiling to multiple packages golang/protobuf#39)

@anandolee
Copy link
Contributor

Already fixed by
option go_package = "google.golang.org/genproto/protobuf/field_mask;field_mask";

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants