Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

atomic static_assert failed under MacOS Serria with CUDA #2545

Closed
gangliao opened this issue Dec 28, 2016 · 1 comment
Closed

atomic static_assert failed under MacOS Serria with CUDA #2545

gangliao opened this issue Dec 28, 2016 · 1 comment

Comments

@gangliao
Copy link

gangliao commented Dec 28, 2016

// This implementation is transitional and maintains the original API for
// atomicops.h. This requires casting memory locations to the atomic types, and
// assumes that the API and the C++11 implementation are layout-compatible,
// which isn't true for all implementations or hardware platforms. The static
// assertion should detect this issue, were it to fire then this header
// shouldn't be used.
//
// TODO(jfb) If this header manages to stay committed then the API should be
//           modified, and all call sites updated.
typedef volatile std::atomic<Atomic32>* AtomicLocation32;
// static_assert(sizeof(*(AtomicLocation32) nullptr) == sizeof(Atomic32),
//              "incompatible 32-bit atomic layout");
@TeBoring
Copy link
Contributor

TeBoring commented Mar 7, 2017

Seems to be fixed by tensorflow/tensorflow#7364. Feel free to reopen it if it's not fixed.

@TeBoring TeBoring closed this as completed Mar 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants