Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conflicting redefinition of GPBType #449

Closed
jcanizales opened this issue Jun 2, 2015 · 6 comments
Closed

Conflicting redefinition of GPBType #449

jcanizales opened this issue Jun 2, 2015 · 6 comments

Comments

@jcanizales
Copy link
Contributor

The class generated for the well-known-type type.proto, GPBType can't be compiled because its name conflicts with the GPBType enum.
@jcanizales
Copy link
Contributor Author

@thomasvl @TeBoring @dmaclach

@jcanizales
Copy link
Contributor Author

Similarly, GPBField, generated in the same file, conflicts with the GPBField of the runtime.

Maybe well-known-types shouldn't use the same prefix as the library's runtime?

@jcanizales
Copy link
Contributor Author

@murgatroid99 FYI

@jcanizales
Copy link
Contributor Author

Same with GPBValue (defined in struct.proto).

@thomasvl
Copy link
Contributor

thomasvl commented Jun 2, 2015

C++ needed to know about Any to build out support for it, so if ObjC ever does something like that they should probably get the same prefix.

I'll rename the internal types.

@jcanizales jcanizales mentioned this issue Jun 2, 2015
Merged
@thomasvl thomasvl mentioned this issue Jun 9, 2015
Merged
@jcanizales
Copy link
Contributor Author

Fixed by #480.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jcanizales @thomasvl