Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer needed call to AC_PROG_CXX_FOR_BUILD in configure.ac #7413

Closed
Arfrever opened this issue Apr 23, 2020 · 5 comments
Closed

No longer needed call to AC_PROG_CXX_FOR_BUILD in configure.ac #7413

Arfrever opened this issue Apr 23, 2020 · 5 comments
Assignees
Labels
c++ inactive Denotes the issue/PR has not seen activity in the last 90 days.

Comments

@Arfrever
Copy link
Contributor

Arfrever commented Apr 23, 2020

AC_PROG_CXX_FOR_BUILD

This was introduced in commit b40d318 (by @acozzette) on 2017-01-03 along with m4/ax_prog_cc_for_build.m4 and m4/ax_prog_cxx_for_build.m4 files (copied from GNU Autoconf Archive project).

However commit b3e4e3a (by @xfxyjwf) on 2018-06-01 deleted usage of CXX_FOR_BUILD variable in src/Makefile.am. No other usage of *_FOR_BUILD variables remains.

So call to AC_PROG_CXX_FOR_BUILD macro in configure.ac and m4/ax_prog_cc_for_build.m4 and m4/ax_prog_cxx_for_build.m4 files are now useless and should be deleted.

@Arfrever
Copy link
Contributor Author

Also issue #3141 will become obsolete afterwards.

@Arfrever
Copy link
Contributor Author

@acozzette: Ping.

--- a/configure.ac
+++ b/configure.ac
@@ -75,7 +75,6 @@
 # Checks for programs.
 AC_PROG_CC
 AC_PROG_CXX
-AC_PROG_CXX_FOR_BUILD
 AC_LANG([C++])
 ACX_USE_SYSTEM_EXTENSIONS
 m4_ifdef([AM_PROG_AR], [AM_PROG_AR])

Followed by git rm m4/ax_prog_cc_for_build.m4 m4/ax_prog_cxx_for_build.m4.

@xen0n
Copy link

xen0n commented May 3, 2023

Drive-by triage (while trying to bump the Gentoo package): this is no longer relevant since #10132 removed the autotools machinery.

Copy link

We triage inactive PRs and issues in order to make it easier to find active work. If this issue should remain active or becomes active again, please add a comment.

This issue is labeled inactive because the last activity was over 90 days ago.

@github-actions github-actions bot added the inactive Denotes the issue/PR has not seen activity in the last 90 days. label Mar 11, 2024
Copy link

We triage inactive PRs and issues in order to make it easier to find active work. If this issue should remain active or becomes active again, please reopen it.

This issue was closed and archived because there has been no new activity in the 14 days since the inactive label was added.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ inactive Denotes the issue/PR has not seen activity in the last 90 days.
Projects
None yet
Development

No branches or pull requests

4 participants