Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add annotations for exporting generated functions from a Windows DLL #13726

Open
dawidcha opened this issue Aug 24, 2023 · 5 comments
Open

Add annotations for exporting generated functions from a Windows DLL #13726

dawidcha opened this issue Aug 24, 2023 · 5 comments
Labels
inactive Denotes the issue/PR has not seen activity in the last 90 days.

Comments

@dawidcha
Copy link

I'm currently engaged in some work with gRPC aiming at merging a PR which permits gRPC to be built as a dynamic library under Windows (i.e. a DLL). here. gRPC makes use of μpb and needs to expose symbols generated by it from a DLL. That requires that the functions marked as extern be annotated with '__declspec(dllexport)' when compiled and '__declspec(dllimport)' when consumed.

For the protoc compiler, this is achieved by prefixing the file output location on the command line with dllexport_decl=MY_EXPORT_MACRO, and then defining MY_EXPORT_MACRO as either __declspec(dllimport) or __declspec(dllexport); or empty string, as appropriate, but this feature doesn't appear to be available in μpb.

Can something similar be added?

@acozzette acozzette transferred this issue from protocolbuffers/upb Aug 29, 2023
Copy link

We triage inactive PRs and issues in order to make it easier to find active work. If this issue should remain active or becomes active again, please add a comment.

This issue is labeled inactive because the last activity was over 90 days ago.

@github-actions github-actions bot added the inactive Denotes the issue/PR has not seen activity in the last 90 days. label Nov 28, 2023
@h-vetinari
Copy link
Contributor

Not stale.

@github-actions github-actions bot removed the inactive Denotes the issue/PR has not seen activity in the last 90 days. label Nov 29, 2023
Copy link

We triage inactive PRs and issues in order to make it easier to find active work. If this issue should remain active or becomes active again, please add a comment.

This issue is labeled inactive because the last activity was over 90 days ago.

@github-actions github-actions bot added the inactive Denotes the issue/PR has not seen activity in the last 90 days. label Feb 27, 2024
@h-vetinari
Copy link
Contributor

This is not stale, and there's an on open PR for this as well, at least in the context of upb (for now): #14981

@github-actions github-actions bot removed the inactive Denotes the issue/PR has not seen activity in the last 90 days. label Feb 28, 2024
Copy link

We triage inactive PRs and issues in order to make it easier to find active work. If this issue should remain active or becomes active again, please add a comment.

This issue is labeled inactive because the last activity was over 90 days ago.

@github-actions github-actions bot added the inactive Denotes the issue/PR has not seen activity in the last 90 days. label May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
inactive Denotes the issue/PR has not seen activity in the last 90 days.
Projects
None yet
Development

No branches or pull requests

2 participants