Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Override removeAllListeners in ServiceEmitter #12

Closed
joshuamarquez opened this issue Mar 1, 2017 · 1 comment
Closed

Override removeAllListeners in ServiceEmitter #12

joshuamarquez opened this issue Mar 1, 2017 · 1 comment

Comments

@joshuamarquez
Copy link
Contributor

Override removeAllListeners() inherited from EventEmitter in ServiceEmitter to avoid removing also newListener and removeListener events when calling it.

We should iterate all instance listeners and skip newListener and removeListener events from being removed.
@joshuamarquez
Copy link
Contributor Author

This issued was resolved with #13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joshuamarquez