Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

visibility-modifier-order false positive in case of payable argument and custom modifier #249

Closed
ZumZoom opened this issue Sep 23, 2020 · 0 comments · Fixed by #269
Closed
Assignees
Labels

Comments

@ZumZoom
Copy link

ZumZoom commented Sep 23, 2020

contract C {
    modifier m() {
        _;
    }

    function foo(address payable addr) public payable m {
        addr;
    }
}

This contract triggers Visibility modifier must be first in list of modifiers however visibility modifier is already first in list of modifiers. Issue is reproduced only with address payable argument, payable modifier and a custom modifier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants