Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor handler classes to remove duplication #36

Closed
2 tasks done
kristjank opened this issue Jun 5, 2020 · 0 comments · Fixed by #39
Closed
2 tasks done

refactor handler classes to remove duplication #36

kristjank opened this issue Jun 5, 2020 · 0 comments · Fixed by #39
Assignees
@KovacZan
Labels
enhancement New feature or request
Projects
NFT

Comments

@kristjank
Copy link
Contributor

kristjank commented Jun 5, 2020 •
edited by KovacZan
Loading

Introduce a new class in between - same way as magistrate-handlers and pull out logic from GTI to that handler implementation (generic part)

  • base-transactions
  • exchange-transactions
@kristjank kristjank added the enhancement New feature or request label Jun 5, 2020
@kristjank kristjank added this to To do in NFT via automation Jun 5, 2020
@KovacZan KovacZan linked a pull request Jun 8, 2020 that will close this issue
refactor(nft-base-transactions + nft exchange-transactions): introducted abstract handler and pulled out duplicate code #39
Merged
3 tasks
NFT automation moved this from To do to Done Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KovacZan KovacZan

Labels
enhancement New feature or request
Projects
No open projects
NFT
  
Done
Milestone
No milestone
2 participants
@kristjank @KovacZan