Add eth_getBlockByHash/Number to engine API #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
protolambda
reviewed
May 11, 2022
|
Related: #24 |
protolambda
approved these changes
May 12, 2022
engine.go
Outdated
| if err != nil { | ||
| return nil, err | ||
| } | ||
| if inclTx { |
There was a problem hiding this comment.
The parameter name is confusing (inclTx but really includes Td instead), and it's always set to true.
There was a problem hiding this comment.
I agree. From geth's ethapi I'd avoid deviating since it'll be even more confusing!
There was a problem hiding this comment.
maybe could link to the upstream code in the function docstring 🤔
|
@protolambda could you enable and run the CI workflow for this PR? an admin needs to do that for PRs of first-time contributors. |
engine.go
Outdated
| @@ -267,3 +274,63 @@ func (e *EngineBackend) ForkchoiceUpdatedV1(ctx context.Context, heads *types.Fo | |||
|
|
|||
| return &types.ForkchoiceUpdatedResult{PayloadStatus: types.PayloadStatusV1{Status: types.ExecutionValid, LatestValidHash: &heads.HeadBlockHash}, PayloadID: &id}, nil | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Super minor suggestion but I think the code will be more maintainable longer-term if the EthBackend was moved to eth.go and the new RPCMarshal functions moved to types/rpc_encoding.go
metachris
approved these changes
May 13, 2022
lightclient
approved these changes
May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Registers and enables eth API namespace with EngineBackend.
For now only implements
eth_getBlockByHashandeth_getBlockByNumberin limited fashion (no full transactions and no pending blocks).