Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local compilation #7

Closed
D1ag0n-Young opened this issue Nov 6, 2019 · 5 comments
Closed

Local compilation #7

D1ag0n-Young opened this issue Nov 6, 2019 · 5 comments

Comments

@D1ag0n-Young
Copy link

D1ag0n-Young commented Nov 6, 2019

Can I clone the project successfully compiled with XCode11.2 locally? Follow the prompts to run the project,I am getting the following error when compiling:
No such module 'EllipticCurveKeyPair' BioProtection.swift and
Command CompileSwift failed with a nonzero exit code

@D1ag0n-Young
Copy link
Author

D1ag0n-Young commented Nov 6, 2019

Can I clone the project successfully compiled with XCode11.2 locally? Follow the prompts to run the project,I am getting the following error when compiling:
No such module 'EllipticCurveKeyPair' BioProtection.swift and
Command CompileSwift failed with a nonzero exit code

@zhj4478

@D1ag0n-Young D1ag0n-Young reopened this Nov 6, 2019
@mackuba
Copy link

mackuba commented Nov 7, 2019

Did you open the project through .xcworkspace? The EllipticCurveKeyPair module seems to come from a CocoaPod included in the repo.

@D1ag0n-Young
Copy link
Author

D1ag0n-Young commented Nov 8, 2019

Did you open the project through .xcworkspace? The EllipticCurveKeyPair module seems to come from a CocoaPod included in the repo.

Thank you very much for your answer, the problem has been solved, but there has been a new problem:
error: "ProtonMail" requires a provisioning profile with the App Groups, In-App Purchase, Siri, iCloud, and Push Notifications features. Select a provisioning profile in the Signing & Capabilities editor. (in target 'ProtonMail' from project 'ProtonMail')

error: "Siri" requires a provisioning profile. Select a provisioning profile in the Signing & Capabilities editor. (in target 'Siri' from project 'ProtonMail')

Is it I what forgot?

@mackuba
Copy link

mackuba commented Nov 8, 2019

They use manual certificate/provisioning setup, so Xcode expects all required certificates & provisioning profiles to be there in your developer account (for the given app ID). The problem is that you can't even create them for that app ID, because this ID is assigned to ProtonMail's account. So you need to come up with some other, like if you created your own app (I used eu.mackuba.ProtonMail), and replace the ch.protonmail.protonmail in all relevant targets (ProtonMail, Share, Push, PushService and Siri, leave the .Share etc. suffixes for each target). You probably also need to update the ID in the same way in App Groups and Keychain Sharing sections. And of course choose your team in the Team selector.

And then you either create all provisioning profiles manually, or just turn on automatic provisioning in all these targets like I did :)

I also had to update the IDs and my team identifier (the one which is now 2SB5Z68H26) in KeychainWrapper.swift and in ProtonMailCommon/Constants/App.swift.

@zhj4478
Copy link
Contributor

zhj4478 commented Nov 8, 2019

@mackuba, thank you for that. it is exactly what you said.
we will try to update the readme and put this in the setup section.

@zhj4478 zhj4478 closed this as completed Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants