Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce number of modules #141

Closed
kshchepanovskyi opened this issue Oct 4, 2015 · 4 comments
Closed

Reduce number of modules #141

kshchepanovskyi opened this issue Oct 4, 2015 · 4 comments
Labels
Milestone

Comments

@kshchepanovskyi
Copy link
Member

Seems that some modules can be joined together:

  • protostuff-runtime-view
  • protostuff-runtime-registry
  • protostuff-collectionschema

They all can be just merged into protostuff-runtime.

@dyu what do you think? Are there any good reasons to keep them as is and release as separate jars?

@dyu
Copy link
Member

dyu commented Oct 5, 2015

They can be merged sure, but registry and view are optional dependencies. Which is why they're separate. The collectionschema can be used standalone, when you just want to extend a schema based on your custom datastructure/container impl.

@kshchepanovskyi
Copy link
Member Author

registry and view are optional dependencies

Right, but they are so small so I think it is better to make them part of protostuff-runtime.

In general, I would like to do some simplification of the project structure. And if there are some things that can be merged together (like a module with two classes), or even remove - better to do it, because support costs are high. Especially when some things are not covered by automated tests (like some code generators).

@dyu
Copy link
Member

dyu commented Oct 6, 2015

Ok, they can be merged. The users just need to use a tool to strip unused dependencies, that is, if that kind of thing is important to them.

@kshchepanovskyi
Copy link
Member Author

Yes - if size matters. On android it is a common practice.
For server-side projects - I hardly believe somebody really does this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants