Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning in IE when ActiveX is deactived #151

Closed
jwestbrook opened this issue Apr 22, 2014 · 2 comments
Closed

Warning in IE when ActiveX is deactived #151

jwestbrook opened this issue Apr 22, 2014 · 2 comments

Comments

@jwestbrook
Copy link
Collaborator

previous lighthouse ticket #2131
by Natasha


Hi everybody,

I'm really desperate - please, please I need your help:

In case that your Internet Explorer (at least in version 8 + 9) is configured NOT to allow Active-X then the following JavaScript command

document.createElement('object')
will cause a warning
An add-on for this website failed to run. Check the security settings in the Internet options for potential conflicts
.
In prototype.js that "createElement('object')" command is triggered each time the library is loaded (which is normally: always) because of the following line

var HTMLOBJECTELEMENT_PROTOTYPE_BUGGY = checkDeficiency('object');
or (depending on the prototype version)

var HTMLOBJECTELEMENT_PROTOTYPE_BUGGY = checkElementPrototypeDeficiency('object');
Am I the only one who things that this is very annoying and not a good idea?
What exactly is the reason for this HTMLOBJECTELEMENT_PROTOTYPE_BUGGY hack (it's not commented at all)?
Are there any fixes/suggestions regarding that problem?
What exactly will happen if I just replace the line above by

var HTMLOBJECTELEMENT_PROTOTYPE_BUGGY = false;
?
Thank you very much in advance for your dear help.

Hugs
Natasha

@jwestbrook
Copy link
Collaborator Author

Natasha
March 28th, 2013 @ 11:17 AM
What about the following solution?

  // PATCH: In case of IE with deactivated ActiveX checkDeficiency('object') will cause a warning.
  // HTMLOBJECTELEMENT_PROTOTYPE_BUGGY shall be true for IE with version less than 9 (indicated by a unknown document.addEventListener function)
  // and it shall be false for all IEs with a version greater or equal 9.
  // For all non-IE browsers we use the checkDeficiency function.
  var HTMLOBJECTELEMENT_PROTOTYPE_BUGGY = (Prototype.Browser.IE ? (typeof document.addEventListener !== 'function') : checkDeficiency('object'));

Thanks and bye
Natasha

@savetheclocktower
Copy link
Collaborator

We ended up fixing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants