New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for cucumberjs v1.1.0 registerHandler api #38
Labels
Comments
AFAIK it was just showing the deprecation message. OP may have seen different results. |
@mattfritz Updated the ticket. It was a combination of warning + unrelated error (callbacks + promises at the same time from 1.1.0) that didn't have an error output that made it seem like this was a breaking change |
Any reason the pull request hasn't been brought in? |
this has been incorporated in v1.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
cucumber/cucumber-js@7d7ba96
has changed the way registerHandler is implemented by deprecating getPayloadItem
see https://github.com/cucumber/cucumber-js/blob/7d7ba96262031b4fb7ab83216f474817d3892f3f/lib/cucumber/runtime/event.js#L14
EDIT: Actually the break is from the use of of callback and returning a promise.
But since that was the error displayed I assumed it was the cause
(Currently it breaks when used with cucumberjs 1.1.0 and protractor 2.3.0)The text was updated successfully, but these errors were encountered: