Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin for DKIM Verifier #826

Merged
merged 2 commits into from Jul 1, 2014

Conversation

lieser
Copy link
Contributor

@lieser lieser commented Jun 30, 2014

Added plugin to support DKIM Verifier add-on

protz added a commit that referenced this pull request Jul 1, 2014
@protz protz merged commit 3a0f09e into thunderbird-conversations:master Jul 1, 2014
@protz
Copy link
Collaborator

protz commented Jul 1, 2014

Thanks!

@protz
Copy link
Collaborator

protz commented Jul 1, 2014

Quick testing indicates that this doesn't break anything; however, with DKIM Verifier installed, and running Daily, I don't see the notifications. Am I missing something?

@lieser
Copy link
Contributor Author

lieser commented Jul 1, 2014

Maybe you simply didn't view an e-mail with a DKIM signature.
The signature is in the header field "DKIM-Signature".

Some e-mail sender who sign e-mails via DKIM are:
amo-editors@mozilla.org (by email-od.com; so all the e-mails about reviews received from Mozilla should have a DKIM signature)
gmail (note that e-mails that you sent to yourself are not signed)
paypal
amazon
ebay

I could send you a signed e-mail from a gmail account, if you want to.
Another way to test this would be to deliberately let an e-mail fail, even if it has no DKIM signature, by creating a sign rule saying that the e-mail should be signed (In options > general > policy).

@protz
Copy link
Collaborator

protz commented Jul 1, 2014

I forgot to mention that the dkim-signed field is properly shown when
using the "classic view".

~ jonathan

On 07/01/2014 11:30 AM, lieser wrote:

Maybe you simply didn't view an e-mail with a DKIM signature.
The signature is in the header field "DKIM-Signature".

Some e-mail sender who sign e-mails via DKIM are:
amo-editors@mozilla.org mailto:amo-editors@mozilla.org (by
email-od.com; so all the e-mails about reviews received from Mozilla
should have a DKIM signature)
gmail (note that e-mails that you sent to yourself are not signed)
paypal
amazon
ebay

I could send you a signed e-mail from a gmail account, if you want to.
Another way to test this would be to deliberately let an e-mail fail,
even if it has no DKIM signature, by creating a sign rule
https://github.com/lieser/dkim_verifier/wiki/Sign-rules saying that
the e-mail should be signed (In options > general > policy).


Reply to this email directly or view it on GitHub
#826 (comment).

@lieser
Copy link
Contributor Author

lieser commented Jul 1, 2014

Have you enabled debugging in the DKIM Verifier add-on to see if the validation of the signature is started?
If the validation is not started, and no error is shown, I would guess that the modules/plugins/dkimVerifier.js file is not loaded for some reason. Have you already tried to debug it?

As I can not reproduce it: have you already tried it with a clean profile? Also, could you sent me your packed xpi to dkim.verifier.addon@gmail.com? Maybe the reason I can not reproduce it is because we packed it differently.

@protz
Copy link
Collaborator

protz commented Jul 1, 2014

My bad! I forgot to restart my Thunderbird instance after checking out
your branch.

Sorry for the noise :)

~ jonathan

On 7/1/2014, 2:51:11 PM, lieser wrote:

Have you enabled debugging in the DKIM Verifier add-on to see if the
validation of the signature is started?
If the validation is not started, and no error is shown, I would guess
that the |modules/plugins/dkimVerifier.js| file is not loaded for some
reason. Have you already tried to debug it?

As I can not reproduce it: have you already tried it with a clean
profile? Also, could you sent me your packed xpi to
dkim.verifier.addon@gmail.com mailto:dkim.verifier.addon@gmail.com?
Maybe the reason I can not reproduce it is because we packed it
differently.


Reply to this email directly or view it on GitHub
#826 (comment).

@ovari ovari mentioned this pull request Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants