Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick reply/replyAll fails if identity has null doCcList or doBccList #662

Closed
nauhygon opened this issue Oct 27, 2012 · 1 comment
Closed

Comments

@nauhygon
Copy link

Whenever I hit the quick Reply or ReplyAll button, the To and Cc fields were not populated. In the Error console, I saw this error message:

Error: [Exception... "'TypeError: aDefault is null' when calling method: [nsIStreamListener::onStopRequest]" nsresult: "0x8057001c (NS_ERROR_XPC_JS_THREW_JS_OBJECT)" location: "native frame :: :: <TOP_LEVEL> :: line 0" data: no]

Digging a little deeper, I found that in stub.composed-ui.js, the identity in ComposeSession instance has doCc set to true, but doCcList to null. This fails mergeDefault() in changeComposeFields(), leaving the To, Cc, and Bcc fields unfilled.

I am not sure if this is also happening to others. Looking through the issues, I am not seeing this particular issue. It may have been just a very special case for me as in about::config, I don't see mail.identity..doCcList.

Fix seems simple and hopefully safe. I will supply a patch shortly.

nauhygon pushed a commit to nauhygon/GMail-Conversation-View that referenced this issue Oct 27, 2012
protz added a commit that referenced this issue Oct 27, 2012
@protz
Copy link
Collaborator

protz commented Oct 27, 2012

Patch merged, thanks for the detailed explanation and rationale!

@protz protz closed this as completed Oct 27, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants