Fix suggestions when adding a new contact to an email. #1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool! Does it also fix the "quick reply"? (Replying inline to an email) |
|
Adding contacts in the quick reply now works. Or did you mean something else? |
protz
added a commit
that referenced
this pull request
Feb 22, 2016
Fix suggestions when adding a new contact to an email.
|
That seems to fix pretty much everything. Thank you so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes:
Timestamp: 02/17/2016 02:46:52 PM
Error: TypeError: entries(...).map is not a function
Source File: chrome://conversations/content/stub.completion-ui.js
Line: 96
And allows to see the suggested contacts when adding a new contact to an email!