Add feeGranter property to BaseReq #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Mike! |
mtps
approved these changes
Jan 19, 2022
leeduan
approved these changes
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the missing optional
feeGranterproperty inBaseReqlike that in the service-walletGrpcClientimplementation inpb-clienthttps://github.com/FigureTechnologies/service-wallet/blob/f413cb16e111095a98a6b26f5f43e1e69fc22deb/pb-client/src/main/kotlin/com/figure/wallet/pbclient/client/GrpcClient.kt#L42@vwagner I don't know if this purposefully left out, or was added later to service-wallet but not yet reflected in this repo.
It was originally added to wallet-service by @tbrooks-figure and relates to work @mplokita-figure is currently doing.