Wrapping current gas estimators with fetchable gas pricing #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtps
requested review from
afremuth-figure,
arnabmitra,
piercetrey-figure and
jdfigure
and removed request for
vwagner
vwagner
approved these changes
Mar 1, 2022
arnabmitra
reviewed
Mar 1, 2022
| */ | ||
| open class UrlGasPrices(private val uri: String) : GasPrices { | ||
| private val client = HttpClientBuilder.create().build() | ||
| private val gson = Gson().newBuilder().create() |
There was a problem hiding this comment.
jackson wasn't in the current deps. gson was. 🤷
arnabmitra
approved these changes
Mar 1, 2022
| @@ -77,6 +80,12 @@ open class PbClient( | |||
| val upgradeClient = cosmos.upgrade.v1beta1.QueryGrpc.newBlockingStub(channel) | |||
| val wasmClient = cosmwasm.wasm.v1.QueryGrpc.newBlockingStub(channel) | |||
|
|
|||
| // @TestnetFeaturePreview | |||
There was a problem hiding this comment.
@mtps did you mean to leave this commented out?
There was a problem hiding this comment.
I removed it in the spirit of quick iteration. I like the concept of guarding in this manner though.
|
|
||
| override fun invoke(): CoinOuterClass.Coin { | ||
| val result = client.execute(HttpGet(uri)) | ||
| require(result.statusLine.statusCode in 200..299) { |
There was a problem hiding this comment.
do we want to have a (optional, use if supplied) fallback default price to use in the event that the uri is unreachable?
There was a problem hiding this comment.
cached values would still exist for the transaction (if caching is enabled). what would we fall back to? (semi-rhetorical question, i honestly don't know what a good "fallback" value would be).
wrouten-figure
approved these changes
Mar 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fromSimulation(), logic moved into cosmosSimulation estimator.Example Usage: