Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force transfer permission #1829

Closed
4 tasks
ysong-figure opened this issue Feb 1, 2024 · 0 comments · Fixed by #1831
Closed
4 tasks

Force transfer permission #1829

ysong-figure opened this issue Feb 1, 2024 · 0 comments · Fixed by #1831
Assignees
@SpicyLemon
Labels
marker Marker Module
Milestone
v1.18.0

Comments

@ysong-figure
Copy link

ysong-figure commented Feb 1, 2024 •
edited

Summary

Add new permission "force transfer" and can only sign this permission for certain addresses.

We only want to give a certain address the force transfer permission, but currently when we set marker force transferable, it makes all the addresses with "TRANSFER" permission able to do the force transfer, which causes a serious security issue.

Proposal

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@SpicyLemon SpicyLemon self-assigned this Feb 2, 2024
@SpicyLemon SpicyLemon added the marker Marker Module label Feb 2, 2024
@SpicyLemon SpicyLemon added this to the v1.18.0 milestone Feb 2, 2024
@SpicyLemon SpicyLemon mentioned this issue Feb 2, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SpicyLemon SpicyLemon

Labels
marker Marker Module
Projects
Provenance Core Protocol Team
Status: Done
Milestone
v1.18.0
Development

Successfully merging a pull request may close this issue.

Require new force_transfer access to do forced transfers. provenance-io/provenance
2 participants
@SpicyLemon @ysong-figure