New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add context field to sessions. #278
Conversation
# Conflicts: # CHANGELOG.md
Codecov Report
@@ Coverage Diff @@
## main #278 +/- ##
==========================================
+ Coverage 49.97% 50.24% +0.27%
==========================================
Files 119 119
Lines 10931 11025 +94
==========================================
+ Hits 5463 5540 +77
- Misses 4930 4938 +8
- Partials 538 547 +9
|
@dwedul-figure I think we will need a way to set this context on the |
… before sending it so that the errors are easier to figure out.
Doh! Yup. Totally forgot that part. Fixed now though. I added it to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing to potentially look for is a validation function for that proto any type url ... there are restrictions on the values that are allowed in there per spec... but I wouldn't try to write your own if there isn't one easily usable within the protobuf SDK.
source: https://github.com/protocolbuffers/protobuf/blob/master/src/google/protobuf/any.proto |
I think I am running into issues when sending an Any value related to the stuff @iramiller mentioned above. I have tried several different ways (different prefixes, setting the any type url to Initially I was using a proto from within p8e, but then switched to this UUID proto that is present in the provenance p8e protos, hoping that it would resolve, but no luck so far. Is there another way I should be specifying the Any type url? |
…ing something weird with the Any types.
… imported twice into the cli_test unit tests.
# Conflicts: # CHANGELOG.md # x/metadata/client/cli/tx.go
Note for the future: The Cosmos SDK was trying to do some automatic validation of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I like the edits to the cobra commands.
Description
Add a
context
field to theSession
message.Also add a
write-session
CLI command and standardize theUse
lines for the metadata tx CLI commands based on the cobra documentation.closes: #276
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes