Fix handling of --page-key value to expect a base64 encoded string

[dwedul-figure]

Summary of Bug

With pagination, there's a next_key value that is a byte array. The CLI outputs byte arrays as base64 encoded values.

However, the ReadPageRequest function converts the provided --page-key string to a byte array by casting it: []byte(pageKey). That means that if you copy a next_key from a result and provide it as the --page-key in a new request, you get unexpected result. The resulting key in the request wasn't base64 decoded, so it's pretty close to just a random value.

Version

1.3.0

More Details

Anywhere we are calling the ReadPageRequest function, we need to base64 decode the --page-key string first.

From cosmwasm:

// sdk ReadPageRequest expects binary but we encoded to base64 in our marshaller
func withPageKeyDecoded(flagSet *flag.FlagSet) *flag.FlagSet {
	encoded, err := flagSet.GetString(flags.FlagPageKey)
	if err != nil {
		panic(err.Error())
	}
	raw, err := base64.StdEncoding.DecodeString(encoded)
	if err != nil {
		panic(err.Error())
	}
	flagSet.Set(flags.FlagPageKey, string(raw))
	return flagSet
}

We need to create a similar function for our CLI stuff to use. Then, wherever we call ReadPageRequest(cmd.Flags()) we would change that to ReadPageRequest(withPageKeyDecoded(cmd.Flags())).

Here's currently all the places that need updating.

> grep -Irsn --exclude-dir vendor ReadPageRequest *
x/attribute/client/cli/query.go:93:			pageReq, err := client.ReadPageRequest(cmd.Flags())
x/attribute/client/cli/query.go:141:			pageReq, err := client.ReadPageRequest(cmd.Flags())
x/attribute/client/cli/query.go:187:			pageReq, err := client.ReadPageRequest(cmd.Flags())
x/marker/client/cli/query.go:85:			pageReq, err := client.ReadPageRequest(cmd.Flags())
x/marker/client/cli/query.go:131:			pageReq, err := client.ReadPageRequest(cmd.Flags())
x/name/client/cli/query.go:133:			pageReq, err := client.ReadPageRequest(cmd.Flags())
x/metadata/client/cli/query.go:613:	pageReq, e := client.ReadPageRequest(cmd.Flags())
x/metadata/client/cli/query.go:669:	pageReq, e := client.ReadPageRequest(cmd.Flags())
x/metadata/client/cli/query.go:724:	pageReq, e := client.ReadPageRequest(cmd.Flags())
x/metadata/client/cli/query.go:818:	pageReq, e := client.ReadPageRequest(cmd.Flags())
x/metadata/client/cli/query.go:869:	pageReq, e := client.ReadPageRequest(cmd.Flags())
x/metadata/client/cli/query.go:944:	pageReq, e := client.ReadPageRequest(cmd.Flags())
x/metadata/client/cli/query.go:1058:	pageReq, e := client.ReadPageRequest(cmd.Flags())

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned