Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Denom Metadata Governance Proposal Support #369

Closed
4 tasks
iramiller opened this issue Jun 29, 2021 · 0 comments · Fixed by #386
Closed
4 tasks

Denom Metadata Governance Proposal Support #369

iramiller opened this issue Jun 29, 2021 · 0 comments · Fixed by #386
Assignees
Labels
enhancement New feature or request ibc inter-blockchain communication marker Marker Module
Projects
Milestone

Comments

@iramiller
Copy link
Member

Summary

Currently the only way to add denom metadata is via software upgrade or through the severely restricted marker metadata api. Adding metadata for IBC denoms or special markers should be supported via governance proposal so this information can be set without a software upgrade.

Problem Definition

The marker module supports adding limited sets of denom metadata in order to protect against spam or phishing attacks. These restrictions prevent the creation of metadata for IBC denoms or for special display options against markers that have differing names for display units (bitcoin/satoshi) from the expected SI unit prefix method.

Proposal

Add a new governance proposal type to the marker module that would allow full specification of denom metadata without any extra restrictions beyond basic validation.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@iramiller iramiller added enhancement New feature or request marker Marker Module ibc inter-blockchain communication labels Jun 29, 2021
@iramiller iramiller mentioned this issue Jul 7, 2021
4 tasks
@iramiller iramiller added this to the v1.6.0 milestone Jul 20, 2021
@iramiller iramiller added this to Triage in Mainnet via automation Jul 20, 2021
@iramiller iramiller moved this from Triage to To Do in Mainnet Jul 20, 2021
@dwedul-figure dwedul-figure self-assigned this Jul 23, 2021
@iramiller iramiller moved this from To Do to In Progress in Mainnet Jul 27, 2021
Mainnet automation moved this from In Progress to Done Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ibc inter-blockchain communication marker Marker Module
Projects
Mainnet
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants