Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Static version numbers leads to incorrect protos in release #615

Closed
egaxhaj opened this issue Jan 24, 2022 · 1 comment
Closed

Static version numbers leads to incorrect protos in release #615

egaxhaj opened this issue Jan 24, 2022 · 1 comment
Assignees
@egaxhaj
Labels
bug Something isn't working dependencies Pull requests that update a dependency file proto Protobuf files work
Milestone
v1.11.0

Comments

@egaxhaj
Copy link
Contributor

egaxhaj commented Jan 24, 2022

https://github.com/provenance-io/provenance/blob/127dea6e59b54ac3a23920723426347defe6cbd8/protoBindings/gradle.properties#L15:L17

cosmos.version=v0.44.3
wasmd.version=v0.19.0
ibc.version=v1.1.0

Dynamically pull versions from go.mod for each new release.
@egaxhaj egaxhaj added bug Something isn't working dependencies Pull requests that update a dependency file proto Protobuf files work labels Jan 24, 2022
@egaxhaj egaxhaj self-assigned this Jan 24, 2022
@egaxhaj egaxhaj added this to the v1.9.0 milestone Jan 24, 2022
@egaxhaj
Copy link
Contributor Author

egaxhaj commented Feb 7, 2022

Closing. Work done in #630

@egaxhaj egaxhaj closed this as completed Feb 7, 2022
@iramiller iramiller modified the milestones: v1.12.0, v1.11.0 Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@egaxhaj egaxhaj

Labels
bug Something isn't working dependencies Pull requests that update a dependency file proto Protobuf files work
Projects
Provenance Core Protocol Team
Archived in project
Milestone
v1.11.0
Development

No branches or pull requests
2 participants
@iramiller @egaxhaj