Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter Begin Blocker Events that are empty amounts #1822

Closed
4 tasks
nullpointer0x00 opened this issue Jan 24, 2024 · 0 comments · Fixed by #1823
Closed
4 tasks

Filter Begin Blocker Events that are empty amounts #1822

nullpointer0x00 opened this issue Jan 24, 2024 · 0 comments · Fixed by #1823
Assignees
Milestone

Comments

@nullpointer0x00
Copy link
Contributor

Summary

The distribution module within the cosmos-sdk is generating events with nil amounts in the rewards category. This behavior typically occurs in blocks that do not contain any transaction fees. These events, while being recorded, consume a significant amount of disk space without providing useful information or value.

Problem Definition

The primary issue at hand is the unnecessary consumption of disk space caused by the recording of events with nil amounts in the rewards category. These events occur in blocks without transaction fees and contribute to data bloat without adding any functional value. This not only inefficiently utilizes storage resources but also complicates data management and analysis within the Provenance Network.

Including this feature enhances the efficiency of data storage and processing on the network. It presents an opportunity for Provenance to streamline its data handling, ensuring that only relevant and meaningful information is stored.

Proposal

The proposed solution involves introducing a mechanism within the application's BeginBlocker hook (defined in app.go) to filter out events.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

1 participant