Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Type "fork" as possibility of getting a Coin #131

Open
tobias-p opened this issue May 14, 2022 · 3 comments
Open

Add Type "fork" as possibility of getting a Coin #131

tobias-p opened this issue May 14, 2022 · 3 comments
Labels

Comments

@tobias-p
Copy link

tobias-p commented May 14, 2022

in Coinbase, I got some BCH a while ago which was because of the fork of BCH from BTC.

This was already mentioned in my former issue (#130), but in my opinion it would be better to show in the report, that I've got those coins not because of buying or transferring from somewhere.

@jhoogstraat
Copy link
Contributor

I am currently looking into the Coinbase and Coinbase Pro statements.
How does a fork look like in the statement?

@tobias-p
Copy link
Author

Sadly, forks are not included in the statement from Coinbase... It's only known for me, since I've got that back then... Don't know, if it is mentioned in Coinbase Pro.

Nonetheless, the "fork" type would be great for correct representation of the accounts...

@provinzio
Copy link
Owner

provinzio commented May 17, 2022

In that case. Its enough to implement a fork operation, so that it can be used with the custom import.

For that we need to (just an idea of mine. Feel free to implement different :) )

  • add a new operation type ForkGive and ForkGet (like sell and buy)
  • add the matching for the fork (like sell and buy)
  • add a report entry type for the fork. This requires different labels because it's more like a trade. Might be better to implement a base class Abstract tax report entry which is inherited by the current TaxReportEntry and a new TaxTradeReportEntry and inherit this by ForkReportEntry (and later on TradeReportEntry; idea of mine independent of this issue)
  • add it to the tax evaluation function
  • extend report export function so that the new TaxReportType is also Handled

It'll be automatically added to the XLSX report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants