nzbfinder.ws api key not being obscured in logs

[arabcoders]

Is there an existing issue for this?

• I have searched the existing open and closed issues

Current Behavior

The logs in prowlarr showing the api key which make it harder to share logs with devs to diagnose problems.

Expected Behavior

The API key should be obscured. it seem NZBFinder uses &r=api_key instead of the usual &api_key=api_key for their download links.

Steps To Reproduce

In my case downloading deleted nzb trigger this error. for this specfic nzb indexer

Environment

- OS: Linux
- Prowlarr: 1.13.3.4273
- Docker Install: 1.13.3.4273-ls52 by linuxserver.io
- Using Reverse Proxy: Yes
- Browser: Chrome Version 121.0.6167.161 (Official Build) (64-bit)

What branch are you running?

Master

Trace Logs?

Example of API key showing in the logs

NzbDrone.Core.Exceptions.ReleaseDownloadException: Download failed
 ---> NzbDrone.Common.Http.HttpException: HTTP request failed: [400:BadRequest] [GET] at [https://nzbfinder.ws/getnzb?id=filename.nzb&r=api_key_not_removed]
   at NzbDrone.Common.Http.HttpClient.ExecuteAsync(HttpRequest request) in ./Prowlarr.Common/Http/HttpClient.cs:line 128
   at NzbDrone.Core.Indexers.IndexerHttpClient.ExecuteProxiedAsync(HttpRequest request, ProviderDefinition definition) in ./Prowlarr.Core/Indexers/IndexerHttpClient.cs:line 42
   at NzbDrone.Core.Indexers.HttpIndexerBase`1.Download(Uri link) in ./Prowlarr.Core/Indexers/HttpIndexerBase.cs:line 251
<?xml version="1.0" encoding="UTF-8"?>
<error code="300" description="NZB file not found!"/>

   --- End of inner exception stack trace ---
   at NzbDrone.Core.Indexers.HttpIndexerBase`1.Download(Uri link) in ./Prowlarr.Core/Indexers/HttpIndexerBase.cs:line 251
   at NzbDrone.Core.Download.DownloadService.DownloadReport(String link, Int32 indexerId, String source, String host, String title) in ./Prowlarr.Core/Download/DownloadService.cs:line 191
   at NzbDrone.Api.V1.Indexers.NewznabController.GetDownload(Int32 id, String link, String file) in ./Prowlarr.Api.V1/Indexers/NewznabController.cs:line 308

NzbDrone.Common.Http.HttpException: HTTP request failed: [400:BadRequest] [GET] at [https://nzbfinder.ws/getnzb?id=filename.nzb&r=api_key_not_removed]
   at NzbDrone.Common.Http.HttpClient.ExecuteAsync(HttpRequest request) in ./Prowlarr.Common/Http/HttpClient.cs:line 128
   at NzbDrone.Core.Indexers.IndexerHttpClient.ExecuteProxiedAsync(HttpRequest request, ProviderDefinition definition) in ./Prowlarr.Core/Indexers/IndexerHttpClient.cs:line 42
   at NzbDrone.Core.Indexers.HttpIndexerBase`1.Download(Uri link) in ./Prowlarr.Core/Indexers/HttpIndexerBase.cs:line 251
<?xml version="1.0" encoding="UTF-8"?>
<error code="300" description="NZB file not found!"/>

Trace Logs have been provided as applicable. Reports may be closed if the required logs are not provided.

• I have read and followed the steps in the wiki link above and provided the required trace logs - the logs contain trace - that are relevant and show this issue.

[mynameisbogdan]

It is already cleansed in the log files.