Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more HTTP methods #13

Closed
RonNabuurs opened this issue Mar 22, 2018 · 8 comments
Closed

Add more HTTP methods #13

RonNabuurs opened this issue Mar 22, 2018 · 8 comments

Comments

@RonNabuurs
Copy link

Add more HTTP methods like the ones below:

  • PATCH
  • OPTIONS
  • HEAD
@jdnichollsc
Copy link
Member

Can you give me an example using these HTTP verbs?

@RonNabuurs
Copy link
Author

How do you mean an example. It's mostly "cosmetic" though, because you can use an PUT instead of an PATCH, but like said in this answer (https://www.quora.com/What-is-the-difference-between-PUT-POST-and-PATCH-for-RESTful-APIs). An PUT is for overwriting a whole entity and PATCH only for field updates.

HEAD is for only getting the header of a request, so without all the data (this could be handy for validating stuff before making a full request)

OPTIONS is used to receive information of the REST server like communication options. This can also be used for validation in an application.

@jdnichollsc
Copy link
Member

ok, let me do the changes at weekend or you can create a pull request 👍

@jdnichollsc jdnichollsc added this to In Progress in Development May 15, 2018
@jdnichollsc
Copy link
Member

@ronneke1996 please validate the changes before generate a new release e287f94

Thanks in advance 👍

@RonNabuurs
Copy link
Author

Looks fine by me, but at the moment I'm not able to test the code. So only a code review on github has been done by me.

@jdnichollsc
Copy link
Member

@ronneke1996 A moment ago, I reverted all the changes from the master branch to create a pull request to compare with the previous version of the plugin, I'm going to add a property BodyString from the RequestHelper class to send your JSON if you want to use other tool to serialize the code, so let me do that change and improve the code, any comments are really apreciated

Pull request => #18

Regards, Nicholls

@jdnichollsc
Copy link
Member

Check my friend the files modified, thanks for your help and patience! 💯 https://github.com/proyecto26/RestClient/pull/18/files

@jdnichollsc jdnichollsc moved this from In Progress to Done in Development May 19, 2018
@jdnichollsc
Copy link
Member

@ronneke1996 the issue was fixed in the last version
Any comment from the unity store is really appreciated! 👍 https://assetstore.unity.com/packages/tools/network/rest-client-for-unity-102501

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants