Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflicts when using typescript #8

Closed
yyf401238353 opened this issue Nov 22, 2019 · 4 comments
Closed

Conflicts when using typescript #8

yyf401238353 opened this issue Nov 22, 2019 · 4 comments

Comments

@yyf401238353
Copy link

It seems like your code in @ion-phaser/react/dist/types/components/IonPhaser.d.ts overwrites the JSX in @type/react.

@yyf401238353
Copy link
Author

yyf401238353 commented Nov 22, 2019

declare module "react" {
    namespace JSX {
        interface IntrinsicElements {
            'ion-phaser': any;
        }
    }
}

@jdnichollsc
Copy link
Member

@jdnichollsc
Copy link
Member

oh ok, we need to replace that by using global instead:

declare global {
  namespace JSX {
    interface IntrinsicElements {
      'ion-phaser': any;
    }
  }
}

@jdnichollsc
Copy link
Member

Fixed, check the last version 1.2.1! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants