Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should enableUrlBarHiding work in the same manner as enableBarCollapsing ? #30

Closed
jcassidyav opened this issue Apr 15, 2020 · 4 comments

Comments

@jcassidyav
Copy link

Which platform(s) does your issue occur on?

  • Android
  • emulator and device.

Please, provide the following version numbers that your issue occurs with:

  • CLI: 6.5.0
  • Cross-platform modules: 6.5.1
  • Runtime(s):
    tns-android : 6.5.0
    tns-ios : 6.5.0
  • Plugin(s): 2.3.0

Please, tell us how to recreate the issue in as much detail as possible.

I am calling InAppBrowser.open with the property enableUrlBarHiding: false,
Should this prevent the url from being hidden when you scroll down the page on android, in the same manner as enableBarCollapsing: false in IOS, or am I misunderstanding the property?

@jdnichollsc
Copy link
Member

@jcassidyav
Copy link
Author

what happens in IOS is that the url/done buttone etc stays visible at the top of the screen when you scroll down the page when enableBarCollapsing = false.

Should that also be the case in android, i.e. the URL bar always remain visible? ( it doesn't for me, it gets hidden if I scroll down the page )

@jdnichollsc
Copy link
Member

That's the native behavior of both platforms, but any pull request is welcome!

@jdnichollsc
Copy link
Member

Also, this configuration is only applied with iOS >= 11 as you can see here https://github.com/proyecto26/nativescript-inappbrowser/blob/master/src/InAppBrowser.ios.ts#L99

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants