Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Case Sensitive URL Check Prevents Successful Redirect with openAuth on Android #429

Open
Ariflo opened this issue Jul 18, 2023 · 0 comments
Open

Case Sensitive URL Check Prevents Successful Redirect with openAuth on Android #429

Ariflo opened this issue Jul 18, 2023 · 0 comments

Comments

@Ariflo
Copy link

Ariflo commented Jul 18, 2023 •
edited

Issue

The check for event.url.startsWith(returnUrl) here prevented my OAuth session from successfully completing the redirect on Android. As far as I can tell this was due to the fact that we were passing in the app scheme URL in camel case as a redirect. In other words; "AwseomApp://" !== "awesomeapp://".

Suggested fix

Use .toLowerCase() to do a valid equivalent check here.
@Ariflo Ariflo changed the title Check For event.url.startsWith(returnUrl) prevents successful redirect with openAuth Mismatching Cases prevents successful redirect with openAuth Jul 18, 2023
@Ariflo Ariflo changed the title Mismatching Cases prevents successful redirect with openAuth Mis-matching Letter Case prevents successful redirect with openAuth Jul 18, 2023
@Ariflo Ariflo mentioned this issue Jul 18, 2023
Open
@Ariflo Ariflo changed the title Mis-matching Letter Case prevents successful redirect with openAuth Mismatching Letter Case Prevents Successful Redirect with openAuth Jul 18, 2023
@Ariflo Ariflo changed the title Mismatching Letter Case Prevents Successful Redirect with openAuth Mismatching Letter Case Prevents Successful Redirect with openAuth on Android Jul 18, 2023
@Ariflo Ariflo changed the title Mismatching Letter Case Prevents Successful Redirect with openAuth on Android Case Sensitive URL Check Prevents Successful Redirect with openAuth on Android Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Ariflo