Android - how to know when the browser was closed by user?

[mlazari]

I have an intent filter like this in my Android app:

<activity
        android:name=".MainActivity"
        ...
>
        <intent-filter>
            <action android:name="android.intent.action.VIEW" />
            <category android:name="android.intent.category.DEFAULT" />
            <category android:name="android.intent.category.BROWSABLE" />
            <data android:scheme="myapp" android:host="test" />
        </intent-filter>
        ...
</activity>

If I open the browser a page that redirects to myapp://test the browser is dismissed and the result type is "cancel", which makes impossible to distinguish this situation from the situation when the user closed the browser manually.

props.openOAuthUrl(urlThatRedirectsToApp).then((result) => {
  console.log(result); // { type: 'cancel' }, but probably it should be { type: 'dismiss' } so I can know that the user did not close the browser manually
});

The promise is resolved with { type: 'cancel' } here when the browser activity is destroyed:

react-native-inappbrowser/android/src/main/java/com/proyecto26/inappbrowser/RNInAppBrowser.java

Line 121 in af97246

mOpenBrowserPromise.resolve(result);

On iOS when the browser redirects to myapp://test the browser is not dismissed automatically. Instead I detect with Linking that the app was opened with that url, and close the browser from there, which I think is fine:

Linking.addEventListener('url', (url) => {
  InAppBrowser.close();
  console.log('URL: ', url);
});

[jdnichollsc]

Check the documentation of the WebBrowser https://docs.expo.io/versions/latest/sdk/webbrowser#returns

If you want you can propose the change with a pull request to include that into the documentation too (README)

[mlazari]

@jdnichollsc I'm not using Expo, but using this module this seems to be true only for iOS:

When the listener fires, you should call WebBrowser.dismissBrowser() -- it will not automatically dismiss when a deep link is handled.

On Android it's dismissed automatically, but the promise resolves with {type: 'cancel'} instead of {type: 'dismiss'}, no matter if I call InAppBrowser.close(); or not. On iOS it's resolved with {type: 'dismiss'} when it's closed with InAppBrowser.close();.

Here is a minimal example that reproduces the issue: https://github.com/mlazari/in-app-browser-my-app
And here is the difference between the behaviour on iOS and on Android:

[mlazari]

@jdnichollsc I opened a pull request #9
Can you please review it? With that fix the result type is the same as on iOS.

[jdnichollsc]

@mlazari thanks for your excellent contribution and sorry for the delay!

[mlazari]

@jdnichollsc No problem. Thanks.