Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaks build out of the box #39

Closed
meds opened this issue Nov 11, 2018 · 3 comments
Closed

Breaks build out of the box #39

meds opened this issue Nov 11, 2018 · 3 comments

Comments

@meds
Copy link

meds commented Nov 11, 2018

DemoScene\Scripts\MainScript.cs uses EditorUtility so trying to do an actual build breaks as EditorUtility is not present.

Can fix this by wrapping in #if UNITY_EDITOR/#endif.

Is this deliberate or am I missing something? Happy to submit a pull request if former.
@jdnichollsc
Copy link
Member

Any pull request is welcome to improve the demo 👍

@jdnichollsc
Copy link
Member

You can see this conversation (it's related) #22 (comment)

@meds
Copy link
Author

meds commented Nov 16, 2018

No worries, I'm a bit inexperienced with github but I will figure out how to submit a pull request, it should be a fairly minor change :)

@meds meds closed this as completed Nov 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@meds @jdnichollsc