Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename filenames for schemas/routers in APIs #23

Closed
2 tasks done
prrao87 opened this issue Apr 26, 2023 · 1 comment
Closed
2 tasks done

Rename filenames for schemas/routers in APIs #23

prrao87 opened this issue Apr 26, 2023 · 1 comment

Comments

@prrao87
Copy link
Owner

prrao87 commented Apr 26, 2023 •
edited
Loading

To improve clarity, it makes sense to reduce verbosity of the router names

  • The filename wine.py is vague -- it's better to rename the file to be more specific as to what it does, such as retriever.py
  • wine_router can be renamed to simply router, and called using retriever.router from main.py in each FastAPI section
@prrao87 prrao87 mentioned this issue Apr 27, 2023
Closed
@prrao87
Copy link
Owner Author

prrao87 commented May 8, 2023

Fixed in #29

@prrao87 prrao87 closed this as completed May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reorg and renaming files prrao87/db-hub-fastapi
1 participant
@prrao87