Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meilisearch with Pydantic v2 #31

Closed
sanders41 opened this issue Jul 15, 2023 · 2 comments · Fixed by #32
Closed

Meilisearch with Pydantic v2 #31

sanders41 opened this issue Jul 15, 2023 · 2 comments · Fixed by #32

Comments

@sanders41
Copy link
Contributor

I saw you updated Neo4j to use Pydantic 2, meilisearch-python-async has also been updated with support for Pydantic 2. I have been meaning to try that out and see what difference it makes here, but just haven't gotten to it yet.

@prrao87
Copy link
Owner

prrao87 commented Jul 15, 2023

Awesome! Yes, I in fact had some local commits that I haven't pushed yet to run it for the Meilisearch case next... Other than the initial data validation step, are there other areas where the async Meilisearch client is affected by pydantic v2's release?

I'll push my changes later today and maybe you can take a look to see if there's something more to be gained?

@sanders41
Copy link
Contributor Author

The latest update just added support for Pydantic v2, there should be no user facing changes. I'm happy to take a look when you push it if you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants