New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Brigher colours for previews #2164
Comments
I was trying to change a couple of colors, just as test, but the written color seems to be set as darker in the preview. Is anything that make the whole preview darker ? If yes, how can I change it ? I would like to see if the overall visiblity will improve in my monitor |
Even the gap fill color, that should be totally white ('FFFFFF'), is not white by greyish |
Thank you for your suggestion. Please provide a pull request. |
I was trying to do this, just a question: there is "something" that makes all color darker. If I set "FFFFFF" as color, it will be shown as light gray, but not white. Can you point me to the code that currently make the color darker? |
I think that the models are lighted by a virtual spot of light. So, they are not equally colored since shadows are applied. |
Sure but current color schema is too dark, on certain monitors is not very well contrasted. Seems like a low-bright image Look at Simplify or Cura, they both have a much brighter preview, easier to view and with sides of model very visible (more than with slic3r, because it's not darken) |
Yes i totaly agree its very hard to distinguish the speeds in the model because of the blue tones who fade into each other. |
I found that travel color is too dark to see it on black bed color. To understand where travels are I had to change point of view and look them against light sky. I think that having possibility to change bed or travel color will be a great improvement of the program. |
Make it optinal! |
This might interest you: |
Don't know. We need to evaluate. Are these supernew n8bot colors hard coded? Frankly I think most of us are happy with the current color scheme. Do we want the colors chemes to be configurable? And why? Is there a risk that everybody will adjust the colors differently and then if two screenshots are taken of G-code viewer, the colors will be so messed up, that it will become a burden in cooperation because on each screenshot a color will have a different meaning? |
my 2C are that it would be nice to have a options for changeing the colors to another theme. The argument with the "different" meaning is right. But in the end you have the legend. And for cooperation its always best to load the gcode into the the own slicer. |
I will try today to bring the colours closer to the stock colours and see how it looks. The problem with the stock colours is that they seem to be haphazardly chosen and do not have even luminance values. Rather, they don't need to be even, but they need to be... considered, when chosen. I think you will find that many users are not happy with the current prusaslicer visualization, including the colours. The colour choices are not offensive or anything, just not optimal. I will experiment with adding a preferences switch to change the colours, too... but I am also reluctant to have multpiple colour choices for the reason bubnikv mentions: the colours should have a consistent meaning across screenshots, versions, etc. |
@n8bot I applaud the effort!
I am the one who picked the current colors. My priority was clarity while trying to stay close to the previous color scheme. People hate change and are used to what the colors mean, so I didn't want to make life harder for them. I like what you are trying to do. Please don't take my feedback negatively, just sharing my honest first impressions. The colors seem very solarized PrusaSlicer left, n8 right I am so used to RGB <-> XYZ when coloring axis, not a huge fan of changing that. Was this to accommodate people with some type of color blindness? |
Thank you for taking the time to consider this and provide such thoughtful feedback.
I hope I did not offend you with my description of the current colours.
This is the lighting, not the colours that is "solarizing" things. It's not solarization, it's just specular highlights from the new lighting setup I made. I have separated the colours and the lighting changes -- the lighting changes, are, IMO, much more important than changing the colours. In fact, I'm not submitting the colours as a PR! I summitted the lighting improvements as a PR, because they are a more sensible first step in correcting the current colour problems in PrusaSlicer (and, no offense, there are problems.)
I agree with you here. Some of this is due to the lighting (I improved it last night, for exactly this scenario of looking downward at an angle... I'm not sure if you are showing photos with the newest lighting setup (I did not release the binaries for the newest changes, only committed them to my branches. Some of the colours can definitely be swapped around if need be... or not chosen at all! (Remember, I didn't submit this as a PR? :P)
This is precisely the reason. This IS RGB, but for colorblind people. Notice how the colours are red-ish, green-ish, and lue-ish? This is an accessibility-first colour scheme. IMO, accessibility for colours needs to come first (and only!). If "colorblind safe" colours are relegated to a special setting hidden in menus, the colorblind uses are left in the dark when it comes to other users posting screenshots of their slicer setups, etc. In order for accessibility like this to work, it has to be adopted by all. In a sense, we need to accommodate the colourblind by offering compromise for our own colour preferences. But, yes, these colour changes are radical. If radical change is to be made, the time is now. If any change is to be made, the decision must be made: should it be radical, or subtle? IMO, it's time for an attention-grabbing radical change. This will help with marketing, and also show that the Prusa team cares about accessibility for all users. If the changes will be subtle, then forget any radical changes in the near future -- pick one: subtle or radical. (Subtle would be merely adjusting the lighting to render the current stock colours more accurately.) I am not colourblind or anything, I just feel that the "accessibility first" mindset is a productive one. So, last but not least, what I see as the "problems" with the current stock PrusaSlicer colours:
|
I followed this "thread" with awe and, this is my personal opinion, PS should be customizable! |
Thank you for the kind words! As an added example of the colourblind simulations, with the range scale (like for speed, width, flow, etc). In the rainbow spectrum, it is not exactly clear the different meanings of the different colours, without referencing the rainbow in your mind. or looking at the legend. The idea behind the magma spectrum is that it provides a natural gradient that is more obvious to interpret, and especially for colorblind people, to accurately see the most of the spectrum. |
For reference, here is the chart showing the stock prusaslicer colours on top and my (new, "Option 2") colour scheme on the bottom [edit: I slightlty changed this from when I first posted it]: The markings are just for me to keep track of which colour is which and reused where. (Hours of staring at colours makes eyes hurt and colours hard to distinguish lololo.) |
@n8bot I'm sure you know this site: https://ethanschoonover.com/solarized/. |
I'm not sure if I've seen that particular site, but thank you! That is a lovely resource. |
I love the ideas behind the "solarized" theme (not to be confused with the photographic term solarization which was brought up earlier in this thread, lol). The background colour theories are amazing. I love the monotone ranges for content and background. That is truly brilliant. I think the accent colours could be adapted to be better suited for colour blind people. Only small tweaks would be needed, I think. Currently, the red highlight colour loses its meaning entirely when seen by a colourblind person. Now, I'm sure the colour theme I have put into the slicer visualization could be criticized in similar ways, though I've tried to mitigate it. There is no perfect solution, at all. What I would like to see, perhaps, is a blend of the "solarized" theme with colourblind safe theory, like the stuff briefly mentioned in that Adobe blog page. There is already a lot of overlap and similarity between the two schemes. |
That's exactly the point why I think it makes sense to have some predefined themes to choose from. I assume many people coming from other slicers (like me, switching from S3D) will feel more home when they see colors that they are used to in the preview. I would love to see a preset with the colors of S3D, others might like to have (or contribute) a Cura preset.
+1 |
I stumbled upon this while Googling the phrase "prusaslicer feature color scheme." I'm loving PrusaSlicer, coming from Simplify3d, but have been finding myself wishing for S3D's clearer, higher-contrast feature-based color-scheme. I initially thought the colors might be configurable, like in an IDE, and upon not finding anywhere in preferences to change the color scheme, went searching. Definitely +1 for the thoughtful changes being discussed here! |
Same here superslicer lets you change a .ini file and add your own color codes to it |
I think this is done by checking the luminance of the part of the object? |
I haven't seen any possibility to create custom color scheme, so I'm asking here: would be possible to use a brigheter color scheme for the preview mode ? S3D and Cura has both a much ligheter (and easier to see) color scheme.
In the same way most application has a "light" or "darker" color scheme, based on user preferences, a brighter (or darker) preview schema would be usefull, mostly on monitors with bad contrast ratio.
The text was updated successfully, but these errors were encountered: