Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Shard ID Flag for CLI #165

Closed
terencechain opened this issue Jun 8, 2018 · 1 comment
Closed

Implement Shard ID Flag for CLI #165

terencechain opened this issue Jun 8, 2018 · 1 comment
Labels
Good First Issue Good for newcomers
Milestone

Comments

@terencechain
Copy link
Member

We are missing Shard ID from user input. Shard ID will be used for services like p2p, observer and proposer. P2p service needs shard ID to know which network to start p2pServer. Proposer service needs shard ID to know which shard to listen incoming transactions, and package transactions into collations and submit to the SMC.

The geth command will look like this for a proposer to propose collation in shard 0:
geth sharding --actor "proposer" --shardID 0 --datadir ../datadir --password password.txt --networkid 12345

The geth command will look like this for an observer to listen in shard 100:
geth sharding --actor "observer" --shardID 100 --datadir ../datadir --password password.txt --networkid 12345

@terencechain
Copy link
Member Author

Closed via #169

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant