Invert enable-pruning-deposit-proofs (#7565)

Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>

shared/featureconfig/config.go

@@ -187,9 +187,10 @@ func ConfigureBeaconChain(ctx *cli.Context) {
 		log.Warn("Enabling new BLS library blst")
 		cfg.EnableBlst = true
 	}
-	if ctx.Bool(enablePruningDepositProofs.Name) {
-		log.Warn("Enabling pruning deposit proofs")
-		cfg.EnablePruningDepositProofs = true
+	cfg.EnablePruningDepositProofs = true
+	if ctx.Bool(disablePruningDepositProofs.Name) {
+		log.Warn("Disabling pruning deposit proofs")
+		cfg.EnablePruningDepositProofs = false
 	}
 	Init(cfg)
 }

shared/featureconfig/deprecated_flags.go

@@ -12,8 +12,14 @@ var (
 		Usage:  deprecatedUsage,
 		Hidden: true,
 	}
+	deprecatedEnablePruningDepositProofs = &cli.BoolFlag{
+		Name:   "enable-pruning-deposit-proofs",
+		Usage:  deprecatedUsage,
+		Hidden: true,
+	}
 )
 
 var deprecatedFlags = []cli.Flag{
 	exampleDeprecatedFeatureFlag,
+	deprecatedEnablePruningDepositProofs,
 }

shared/featureconfig/flags.go

@@ -92,9 +92,10 @@ var (
 		Name:  "use-check-point-cache",
 		Usage: "Enables check point info caching",
 	}
-	enablePruningDepositProofs = &cli.BoolFlag{
-		Name:  "enable-pruning-deposit-proofs",
-		Usage: "Enables pruning deposit proofs when they are no longer needed. This significantly reduces deposit size.",
+	disablePruningDepositProofs = &cli.BoolFlag{
+		Name: "disable-pruning-deposit-proofs",
+		Usage: "Disables pruning deposit proofs when they are no longer needed." +
+			"This will probably significantly increase the amount of memory taken up by deposits.",
 	}
 )
 
@@ -103,7 +104,6 @@ var devModeFlags = []cli.Flag{
 	enableEth1DataMajorityVote,
 	enableAttBroadcastDiscoveryAttempts,
 	enablePeerScorer,
-	enablePruningDepositProofs,
 }
 
 // ValidatorFlags contains a list of all the feature flags that apply to the validator client.
@@ -153,7 +153,7 @@ var BeaconChainFlags = append(deprecatedFlags, []cli.Flag{
 	enableAttBroadcastDiscoveryAttempts,
 	enablePeerScorer,
 	checkPtInfoCache,
-	enablePruningDepositProofs,
+	disablePruningDepositProofs,
 }...)
 
 // E2EBeaconChainFlags contains a list of the beacon chain feature flags to be tested in E2E.
@@ -162,5 +162,4 @@ var E2EBeaconChainFlags = []string{
 	"--dev",
 	"--enable-eth1-data-majority-vote",
 	"--use-check-point-cache",
-	"--enable-pruning-deposit-proofs",
 }